Conversation
nsthorat
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained (waiting on @kangyizhang)
package.json, line 69 at r1 (raw file):
4 ], "package_name": "CPU-darwin-1.2.6.tar.gz"
is this intended? also did this happen automatically from the release script?
kangyizhang
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained (waiting on @nsthorat)
package.json, line 69 at r1 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
is this intended? also did this happen automatically from the release script?
Yes. It's automatically edited when installing node native addon. It won't affect anything but quite confusing for ourselves. I have filed tensorflow/tfjs#1756 to track
nsthorat
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @nsthorat)
This change is