Make MySQLContainer compatible with mysql:9.3.0#10185
Make MySQLContainer compatible with mysql:9.3.0#10185eddumelendez merged 6 commits intotestcontainers:mainfrom
Conversation
| @@ -19,9 +19,10 @@ public class MySQLRootAccountTest { | |||
| @Parameterized.Parameters(name = "{0}") | |||
| public static DockerImageName[] params() { | |||
| return new DockerImageName[] { | |||
There was a problem hiding this comment.
Did you mean to leave these commented out?
I'd expect that you'd have just needed to add the new image to the list like you have elsewhere.
There was a problem hiding this comment.
Did you mean to leave these commented out? I'd expect that you'd have just needed to add the new image to the list like you have elsewhere.
Hello, I have just finished my holiday. Regarding this issue, it was my negligence and I will deal with this matter.
JackW2000
left a comment
There was a problem hiding this comment.
Change needed to uncomment other test images in MySQLRootAccountTest.java
Config change may also need re-evaluating in the scenario that these currently uncommented images fail without it.
…stem variables is fixed
fd66dbb to
0a8c42e
Compare
|
Thanks for your contribution, @livk-cloud. Please, avoid creating an issue and a PR at the same time. Ideal flow is raising an discussion, convert it into an issue and then raise a PR. For this case, it is understandable to skip the discussion and raise the issue directly. Now, talking about this and the recent changes on mysql, updating the |
JackW2000
left a comment
There was a problem hiding this comment.
Happy that the commented out images are now back so are being included, but there are still test failures on this branch which need to be resolved.
Additionally, as suggested by @eddumelendez, the removal of the config item may not be the best route globally and could do with being investigated prior to the decision to merge.
|
@eddumelendez Thank for your answer. I also support deleting my.cnf. The compatibility issue of multiple versions cannot be resolved. However, the current situation is that Mysql 9.3 Images cannot be started. If you consider supporting 9.3, I think deleting the removed system variables is the easiest. What do you think? |
|
In order to avoid breaking changes for existing users, we should handle |
…tcontainers#10275) Upgrade testImplementation dependency from `com.jcraft:jsch:0.1.55` to `com.github.mwiede:jsch:2.27.0`
|
Thanks for your contribution, @livk-cloud ! |
Fixes #10184