making it a bit easier to run individual tests in Doc.hs#5517
Open
bbarker wants to merge 1 commit intounisonweb:trunkfrom
Open
making it a bit easier to run individual tests in Doc.hs#5517bbarker wants to merge 1 commit intounisonweb:trunkfrom
bbarker wants to merge 1 commit intounisonweb:trunkfrom
Conversation
Contributor
|
Sorry I thought I’d merged this already |
Contributor
|
No wait; this is new 😅 |
aryairani
reviewed
Jan 24, 2025
Comment on lines
+153
to
+154
| where | ||
| simpleScope = fromMaybe "default" $ headMay $ words $ filter isAlphaNum s |
Contributor
There was a problem hiding this comment.
I guess the issue is that some of the test names are not easy (and maybe not possible?) to provide at the command-line, due to weird stuff like newlines. And are there maybe tests with no name at all?
But could you add some comments to the code about what this line is trying to accomplish and why?
Contributor
|
@bbarker Could you add a comment that describes the new actual behavior with this PR, and then assuming no surprises there, I think it's good to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Previously, running e.g.
stack test --fast unison-syntax --ta "DocParser.Hello"Would result in:
Now with this change we get:
I'm not sure this is the best solution, but maybe it is something to start with.