Draft
Conversation
Member
Author
|
Ugh, yeah looks like Windows problems |
Contributor
|
What if instead of a temp file, you temporarily created the |
Contributor
Yeah at least it should be on the same device, which seems to be what's causing the trouble in this case. move/rename from $TEMP could always cause this. a "copy from temp"+delete could also be the fix alternatively |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
@dolio recently had an "idemptotent" transcript file get wiped out because of a ctrl-c at a non-opportune moment.
This makes output-writing atomic on unix systems, and it should be slightly less likely to cause trouble on windows as well.
Implementation notes
Test coverage
Existing transcripts should serve as proof this is working.
I also tried making some transcript changes to ensure they took effect.