Open
Conversation
Introduce the authorization module with CRUD operations for permissions including create, list (paginated), get, update (PATCH), and delete. Register the module on both sync and async clients. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Greptile OverviewGreptile SummaryThis PR introduces a new authorization module to the WorkOS Python SDK, implementing full CRUD operations for permissions. The implementation follows established SDK patterns perfectly, with both synchronous and asynchronous client support, comprehensive test coverage, and proper integration with the existing client architecture. Key changes:
The code is well-structured, follows existing patterns, has no security issues, and includes thorough test coverage including edge cases like pagination. Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Client
participant Authorization
participant HTTPClient
participant API
Client->>Authorization: create_permission(slug, name)
Authorization->>HTTPClient: POST request
HTTPClient->>API: Send request
API-->>HTTPClient: Return permission
HTTPClient-->>Authorization: Process response
Authorization-->>Client: Return Permission
Client->>Authorization: list_permissions()
Authorization->>HTTPClient: GET request with params
HTTPClient->>API: Send request
API-->>HTTPClient: Return list
HTTPClient-->>Authorization: Process response
Authorization-->>Client: Return WorkOSListResource
Client->>Authorization: update_permission(slug, name)
Authorization->>HTTPClient: PATCH request
HTTPClient->>API: Send request
API-->>HTTPClient: Return updated permission
HTTPClient-->>Authorization: Process response
Authorization-->>Client: Return Permission
Client->>Authorization: delete_permission(slug)
Authorization->>HTTPClient: DELETE request
HTTPClient->>API: Send request
API-->>HTTPClient: Acknowledge deletion
HTTPClient-->>Authorization: Process response
Authorization-->>Client: Return None
Last reviewed commit: 30cdb9a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduce the authorization module with CRUD operations for permissions including create, list (paginated), get, update (PATCH), and delete. Register the module on both sync and async clients.
Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.