Skip to content

Comments

Change default regex delimiter to chr(1)#46

Merged
gitlost merged 2 commits intomasterfrom
change-default-delimiter
Aug 30, 2017
Merged

Change default regex delimiter to chr(1)#46
gitlost merged 2 commits intomasterfrom
change-default-delimiter

Conversation

@miya0001
Copy link
Member

@miya0001 miya0001 commented Aug 30, 2017

The useful part is that it can return characters that you cannot easily type, so with something like chr(1), the chances of the delimiter being included in the pattern itself are practically null, whereas a / can easily be part of the actual pattern.

https://github.com/wp-cli/search-replace-command/pull/30/files/4d16b3163a4ef8d424e73aa74aba1b8c804508ef#r136037981

@miya0001 miya0001 requested a review from a team August 30, 2017 14:33
@gitlost gitlost merged commit aab939f into master Aug 30, 2017
@gitlost gitlost deleted the change-default-delimiter branch August 30, 2017 19:50
@gitlost gitlost added this to the 1.2.1 milestone Aug 30, 2017
@gitlost gitlost mentioned this pull request Aug 30, 2017
Merged
@gitlost gitlost mentioned this pull request Oct 13, 2017
Merged
danielbachhuber pushed a commit that referenced this pull request Nov 18, 2022
@gitlost
Merge pull request #46 from wp-cli/change-default-delimiter
5f4ac02 
Change default regex delimiter to `chr(1)`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gitlost gitlost gitlost approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

command:db command:db-search

Projects

None yet

Milestone

1.2.1

Development

Successfully merging this pull request may close these issues.

2 participants

@miya0001 @gitlost