Add skips arg to Utils\report_batch_operation_results().#4429
Merged
danielbachhuber merged 2 commits intomasterfrom Oct 10, 2017
Merged
Add skips arg to Utils\report_batch_operation_results().#4429danielbachhuber merged 2 commits intomasterfrom
danielbachhuber merged 2 commits intomasterfrom
Conversation
Member
I'd actually think this the expected behavior: don't show any message about skips unless a value is explicitly provided. I've updated the PHPDoc accordingly. |
danielbachhuber
approved these changes
Oct 7, 2017
Contributor
Author
If |
Member
|
@gitlost Ah, I understand now. I think the current implementation looks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See wp-cli/media-command#48 (review)
Adds
$skipsarg toUtils\report_batch_operation_results()to report the number of items skipped. Also adds reporting of the number of items that failed.The default has been to set to null which suppresses the reporting of failed items, for back compat with current behaviour. If temporarily breaking the tests for the commands that test for this (
entity-command,extension-command,media-commandandwidget-command) is okay, then the default should be zero instead.