Patch mustache/mustache to avoid throwing notices on PHP 7.4#5306
Merged
schlessera merged 6 commits intomasterfrom Nov 11, 2019
Merged
Patch mustache/mustache to avoid throwing notices on PHP 7.4#5306schlessera merged 6 commits intomasterfrom
mustache/mustache to avoid throwing notices on PHP 7.4#5306schlessera merged 6 commits intomasterfrom
Conversation
Member
Author
|
The problem can be replicated in Travis: https://travis-ci.org/wp-cli/wp-cli/jobs/610329317#L702 |
chesio
added a commit
to chesio/wp-cli
that referenced
this pull request
Dec 11, 2019
Also revert PHP 7.4 patch from wp-cli#5306 that is now no longer necessary.
|
Thanks all. Can we get a point release with this patch, or is that too much work? 2.4.0 is a bit of a pain to use with this. For some reason EDIT addressed in https://wordpress.slack.com/archives/C02RP4T41/p1579795934005500 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also add PHP 7.4 to the testing matrix first to see if we detect this problem in our CI.
Fixes #5304