PHP 8.4 | Update Requests to v 2.0.12#5981
Merged
swissspidy merged 1 commit intowp-cli:mainfrom Sep 20, 2024
Merged
Conversation
Follow up on 5796 Requests 2.0.11 contains a number of PHP 8.4 related fixes, so an update is warranted. Includes updated certificates bundle. Note: I've done the update manually as the `utils/install-requests.sh` script doesn't work on Windows. Wouldn't be a bad idea if someone on *nix ran the script over this commit to verify that my manual update had the same result. I'd also like to suggest maybe creating a GH Actions workflow which automates keeping Requests up to date by: 0. Running as a weekly cron job. 1. Checking the latest released version via the GH API. 2. If it doesn't match the version in `utils/install-requests.sh`, update the version nr in the script. 3. Run the script. 4. Commit the changes and create a pull request for the update. The pull request can still be (manually) tweaked if needed and/or rejected, but at least it takes the "we need to remember to do this" out of the equation. Refs: * https://github.com/WordPress/Requests/releases
79c245e to
887b0bb
Compare
Contributor
Author
|
Rebased without changes after the merge of #5982. This should allow to get a passing build. |
Member
Can confirm 👍 ✅ |
swissspidy
approved these changes
Sep 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #5796
Requests 2.0.11 contains a number of PHP 8.4 related fixes, so an update is warranted.
Includes updated certificates bundle.
Note: I've done the update manually as the
utils/install-requests.shscript doesn't work on Windows. Wouldn't be a bad idea if someone on *nix ran the script over this commit to verify that my manual update had the same result.I'd also like to suggest maybe creating a GH Actions workflow which automates keeping Requests up to date by:
0. Running as a weekly cron job.
utils/install-requests.sh, update the version nr in the script.The pull request can still be (manually) tweaked if needed and/or rejected, but at least it takes the "we need to remember to do this" out of the equation.
Refs: