Draft
Conversation
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
…hars Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix double escaped SSH commands in runner
Fix double-escaped SSH commands
Feb 12, 2026
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSH commands were escaped twice: once when building the command string in
run_ssh_command(), then again when wrapping for shell execution ingenerate_ssh_command(). This produced unnecessarily complex debug output with nested quote escaping.Changes
Modified
run_ssh_command()to apply selective quoting:[a-zA-Z0-9_=.\/:-]+are passed unquotedescapeshellarg()The outer escaping in
generate_ssh_command()remains unchanged, maintaining the two-layer security model.Example
Before:
After:
Arguments with spaces still escape correctly:
Test Coverage
Added Behat scenario
SSH commands should not be double-escapedto verify output format.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.