Disable statement handler when not connected#1059
Open
carlos-granados wants to merge 1 commit intoxdebug:masterfrom
Open
Disable statement handler when not connected#1059carlos-granados wants to merge 1 commit intoxdebug:masterfrom
carlos-granados wants to merge 1 commit intoxdebug:masterfrom
Conversation
47d423f to
cc0005b
Compare
cc0005b to
5941530
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
do_connect_to_clientto true. The code that acts upon this flag is called from the statement handler, so we need to enable it so that it can try to connect. If it does not connect, it will be disabled againThis provides a performance gain between 1% and 10% depending on the type of application that we are running. See some benchmarking results here: https://github.com/carlos-granados/xdebug/actions/runs/21043818969