Conversation
Member
Author
Member
Author
Member
|
I am getting this error:
|
Member
Author
Will be fixed here: https://github.com/components/bootstrap/pull/59/files#diff-b5d0ee8c97c7abd7e3fa29b9a27d1780 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
As part of this PR Bootstrap is upgraded from version 3 to version 4. Also we are simplifying it's integration into the core.
Particularly we completely remove the less/sass meta layer for these main reasons:
So from now on we just treat Bootstrap as what it is - a vendor component - and work with it instead on it.
If somebody wants to further customize things he can still do it. We provide the possibility to use a custom bootstrap css path for that. But Zikula does not have to provide the "source" experience of the whole BS package ootb.
This PR also removes the "zikula.stylesheet.bootstrap-font-awesome.path" because there is no need to have this in one file then anymore. Asset combination can do this instead if desired.
Todos
FormExtensionBundleto Symfony's Bootstrap 4 Form Theme