Merged
Conversation
Requesting WRITE_EXTERNAL_STORAGE on Android R (SDK 30) *always* fails and so the sample app is always immediately closed. This permission has no effect on R+. See: https://developer.android.com/reference/android/Manifest.permission#WRITE_EXTERNAL_STORAGE To save anything in external storage, this sample would have to be migrated to Scoped Storage.
The request code is an "*application specific* request code to match with a result reported to onRequestPermissionsResult". There's no point in using random numbers here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sample is currently broken for devices running Android R+, where requesting WRITE_EXTERNAL_STORAGE always fails which subsequently closes the app because not all permissions are granted.
To save anything in external storage, the sample app would have to be migrated to Scoped Storage (what's in my opinion that's beyond the scope of a sample app).