gh-132106: Allow logging.handlers.QueueListener to be used as a context manager#132107
gh-132106: Allow logging.handlers.QueueListener to be used as a context manager#132107picnixz merged 10 commits intopython:mainfrom
Conversation
Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
…e running (prevents a thread leak) Update docs
There was a problem hiding this comment.
I'd prefer if we can make the multi-start check in a separate PR so that it becomes much easier to revert commits if needs arise. You can re-use the same issue however. We would then merge this PR afterwards (I'll make it so that we don't hang too much on this PR)
|
@picnixz , I removed the listener already started stuff. I'll do a fresh PR after this one merges (since otherwise I'll merge conflict anyways with this one).. (Unless you'd like that one first instead?) |
Thank you! whichsoever order is fine. |
|
All commit authors signed the Contributor License Agreement. |
vsajip
left a comment
There was a problem hiding this comment.
I'd suggest removing the skipUnless ... QueueHandler decorators. Otherwise LGTM, thanks!
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
…lways available now
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @vsajip: please review the changes made to this pull request. |
|
Thanks for the work. You can now fixup the multiple start issue in a new PR but with the same issue number. |
|
📚 Documentation preview 📚: https://cpython-previews--132107.org.readthedocs.build/