gh-132106: Ensure that running logging.handlers.QueueListener cannot be started again#132444
Merged
vsajip merged 2 commits intopython:mainfrom Apr 13, 2025
Merged
Conversation
Prevents a thread leak
logging.handlers.QueueListener cannot be started again
picnixz
approved these changes
Apr 12, 2025
Member
|
This could be backported in some sense since it can be regarded as a bugfix, but I'll let @vsajip decide. |
picnixz
approved these changes
Apr 12, 2025
Member
picnixz
left a comment
There was a problem hiding this comment.
Just some cosmetic improvements for rendering the method's name.
Misc/NEWS.d/next/Library/2025-04-12-09-30-24.gh-issue-132106.OxUds3.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz
approved these changes
Apr 12, 2025
vsajip
approved these changes
Apr 13, 2025
|
Sorry, @csm10495 and @vsajip, I could not cleanly backport this to |
vsajip
pushed a commit
to vsajip/cpython
that referenced
this pull request
Apr 13, 2025
…stener` cannot be started again (pythonGH-132444) Prevents a thread leak Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> (cherry picked from commit 5863cd7) Co-authored-by: Charles Machalow <csm10495@gmail.com>
|
GH-132471 is a backport of this pull request to the 3.13 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gh-132106 - Make it so start can't be called again while running
Helps prevents a thread leak
📚 Documentation preview 📚: https://cpython-previews--132444.org.readthedocs.build/