Skip to content

Comments

[2.4] MOD-4850: Merge all from master towards v2.4.5#927

Merged
oshadmi merged 42 commits into2.4from
oshadmi_cp_master_to_2.4_20230212
Feb 12, 2023
Merged

[2.4] MOD-4850: Merge all from master towards v2.4.5#927
oshadmi merged 42 commits into2.4from
oshadmi_cp_master_to_2.4_20230212

Conversation

@oshadmi
Copy link
Collaborator

@oshadmi oshadmi commented Feb 12, 2023

No description provided.

oshadmi and others added 30 commits November 6, 2022 10:17
* Add to JSONPath filter the regexp match operator

* Improve coverage

* Minor cosmetics

* Allow match using regex pattern from a field and add end-to-end test

* Test with numeric combined in filter

* Add more tests and documentation
* Add details on jsonpath filter

* fix local path and some edits

* Apply suggestions from review by Nermina

Co-authored-by: Nermina Miller <102551568+nermiller@users.noreply.github.com>

Co-authored-by: Nermina Miller <102551568+nermiller@users.noreply.github.com>
Variable fix.

<s>`$search`</s> into `$rejson`

```
rejson=$(docker run -d -it -v $PWD:/build debian:bullseye bash)
docker exec -it $rejson bash
```

Co-authored-by: Guy Korland <gkorland@gmail.com>
Co-authored-by: Guy Korland <gkorland@gmail.com>
* Partial fix for REDISIO-186: JSON broken links

* Applied feedback from Chayim

* Updates examples and restructures sections

* Update docs/commands/json.arrappend.md

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

* Update docs/commands/json.arrappend.md

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

* Update docs/commands/json.arrindex.md

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

* Update docs/commands/json.arrindex.md

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

* Update docs/commands/json.arrinsert.md

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

* Update docs/commands/json.arrindex.md

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

* Update docs/commands/json.arrindex.md

* Update docs/commands/json.arrinsert.md

* Update docs/commands/json.arrlen.md

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

* Update docs/commands/json.arrpop.md

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

* Update docs/commands/json.arrtrim.md

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

* Update docs/commands/json.numincrby.md

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

* Update docs/commands/json.resp.md

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

* Update docs/commands/json.set.md

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

* Update docs/commands/json.strappend.md

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

* Update docs/commands/json.toggle.md

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

* Update docs/commands/json.arrpop.md

* Update docs/commands/json.arrpop.md

* Update docs/commands/json.arrinsert.md

* Update json.arrtrim.md

* Update docs/commands/json.arrappend.md

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

* Update docs/commands/json.arrinsert.md

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

* Update docs/commands/json.arrtrim.md

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

* Update docs/commands/json.arrpop.md

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>
* License change
* License hyperlinks in README.md
* RAMP file fix
* Cargo.toml fix
* Fix spelling wordlist
* Support legacy jsonpath with dollar

* Support legacy jsonpath with dollar

* Fix test
* Fixes #882, explains returns of JSON array and JSON object

* Update docs/commands/json.get.md

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

* Update docs/commands/json.get.md

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>
* add support for arrindex for none scalars

* test no scalar on arrindex

* clean code rename args

* fix tests

* fix tests
* clean clippy warnings


* revert so we can build with Rust 1.60
Co-authored-by: Guy Korland <gkorland@gmail.com>
add focal CI testing on enterprise
* enable tracing jsonpath tests

* add flow test

* Evaluate all filter operands

* Add tests with precedence and nesting

* update spellcheck dictionary

* remove redis-module from dev-dependencies
add cluster versions for release testing
gkorland and others added 11 commits December 29, 2022 16:17
* update to the latest stable rust even if rust installed

* update readies
* straight the error message

* fix build

* format code
* Added `rustis` client library

[rustis](https://github.com/dahomey-technologies/rustis)

* Update README.md

Added rustis client library

* Update README.md

Added rustis documentation link

Co-authored-by: Guy Korland <gkorland@gmail.com>
* break serde-json manager out to a file

* add license header
)

* Enabled Pull Request CI Performance info generation and publishing

* Updated label triggering to ensure default flow is not canceled
* ignore case on spelling

* plugin version bump

* spelling
* disable recursion limit on RDB load
@codecov
Copy link

codecov bot commented Feb 12, 2023

Codecov Report

Base: 81.40% // Head: 81.40% // No change to project coverage 👍

Coverage data is based on head (7356886) compared to base (eb5eba8).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##              2.4     #927   +/-   ##
=======================================
  Coverage   81.40%   81.40%           
=======================================
  Files          15       15           
  Lines        3905     3905           
=======================================
  Hits         3179     3179           
  Misses        726      726           
Impacted Files Coverage Δ
src/jsonpath/mod.rs 85.71% <ø> (ø)
src/lib.rs 86.53% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@oshadmi oshadmi merged commit 4e80773 into 2.4 Feb 12, 2023
@oshadmi oshadmi deleted the oshadmi_cp_master_to_2.4_20230212 branch February 12, 2023 16:59
@oshadmi oshadmi changed the title [2.4] Merge all from master towards v2.4.5 [2.4] MOD-4850: Merge all from master towards v2.4.5 Feb 12, 2023
Copy link

@MeirShpilraien MeirShpilraien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Reviewed the code changes, @rafie please review the build changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.